----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21122/#review42388 -----------------------------------------------------------
Patch looks great! Reviews applied: [21122] All tests passed. - Mesos ReviewBot On May 6, 2014, 6:02 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21122/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 6:02 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > ProcTest.SingleThread is flaky when run after ProcTest.MultipleThreads > (shuffled tests) because /proc takes some time to update after threads have > terminated. Thus if the SingleThread test is run immediately after the > MultipleThreads test it may receive stale information when calling > proc::threads(). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > abd109b937877677ba4dee14178cef220629dd30 > > Diff: https://reviews.apache.org/r/21122/diff/ > > > Testing > ------- > > Bug was easy to reproduce within 1,000 iterations. > > Tested fix with 100,000 iterations. > ./3rdparty/libprocess/3rdparty/stout-tests --gtest_shuffle > --gtest_filter="ProcTest*" --gtest_repeat=100000 --gtest_break_on_failure > > > Thanks, > > Ian Downes > >
