----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21292/#review42733 -----------------------------------------------------------
Ship it! src/log/leveldb.cpp <https://reviews.apache.org/r/21292/#comment76591> You forgot to include <stout/unreachable.hpp> , I'll do it for you. Thank you for the fix! - Jie Yu On May 12, 2014, 7:09 p.m., Vinson Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21292/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 7:09 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1177 > https://issues.apache.org/jira/browse/MESOS-1177 > > > Repository: mesos-git > > > Description > ------- > > From: Vinson Lee <[email protected]> > Date: Fri, 9 May 2014 15:21:25 -0700 > Subject: [PATCH] Add return statement to > mesos::internal::log::Varint64Comparator::Compare. > > This patch fixes this build error with ICC. > > libtool: compile: /opt/intel/bin/icpc -DPACKAGE_NAME=\"mesos\" > -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.19.0\" > "-DPACKAGE_STRING=\"mesos 0.19.0\"" -DPACKAGE_BUGREPORT=\"\" > -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"0.19.0\" -DSTDC_HEADERS=1 > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 > -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 > -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 > -DMESOS_HAS_JAVA=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -DHAVE_LIBZ=1 > -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -Wall -Werror > -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" > -DPKGDATADIR=\"/usr/local/share/mesos\" -I../include > -I../3rdparty/libprocess/include > -I../3rdparty/libprocess/3rdparty/stout/include -I../include > -I../3rdparty/libprocess/3rdparty/boost-1.53.0 > -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src > -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdpa rty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -MT log/liblog_la-leveldb.lo -MD -MP -MF log/.deps/liblog_la-leveldb.Tpo -c log/leveldb.cpp -fPIC -DPIC -o log/.libs/liblog_la-leveldb.o > log/leveldb.cpp(56): error #1011: missing return statement at end of non-void > function "mesos::internal::log::Varint64Comparator::Compare" > } > ^ > > JIRA: MESOS-1177 > Signed-off-by: Vinson Lee <[email protected]> > > > Diffs > ----- > > src/log/leveldb.cpp 7811f2b > > Diff: https://reviews.apache.org/r/21292/diff/ > > > Testing > ------- > > make > > > Thanks, > > Vinson Lee > >
