Hey Ben and Bernardo, I'll get to it during this week. It's pretty crazy here too :-) Maybe Tobi and Connor can chime in on the java doc style.
Cheers, Niklas On Mon, May 12, 2014 at 12:27 PM, Benjamin Mahler <[email protected] > wrote: > Hey Niklas, > > Would you be able to help get all Bernardo's great Javadoc improvements > reviewed and submitted? I'm pretty swamped as of late with 0.19.0 related > things. > > > On Wed, May 7, 2014 at 1:18 PM, Niklas Nielsen <[email protected]> wrote: > >> >> ----------------------------------------------------------- >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/21083/#review42426 >> ----------------------------------------------------------- >> >> >> >> src/java/src/org/apache/mesos/state/State.java >> <https://reviews.apache.org/r/21083/#comment76189> >> >> >> Don't you want to align the @return and @param description here (and >> the two other comment blocks) like in >> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html? >> :) >> >> >> - Niklas Nielsen >> >> >> On May 5, 2014, 11:36 a.m., Bernardo Gomez Palacio wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/21083/ >> > ----------------------------------------------------------- >> > >> > (Updated May 5, 2014, 11:36 a.m.) >> >> > >> > >> > Review request for mesos and Mesos ReviewBot. >> > >> > >> > Bugs: MESOS-1294 >> > https://issues.apache.org/jira/browse/MESOS-1294 >> > >> > >> > Repository: mesos-git >> > >> > >> > Description >> > ------- >> > >> > [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java >> > >> > >> > Diffs >> > ----- >> > >> > src/java/src/org/apache/mesos/state/State.java >> d14d79b4850f677588c928803aba921030571fb8 >> > >> > Diff: https://reviews.apache.org/r/21083/diff/ >> > >> > >> > Testing >> > ------- >> > >> > 1. ./bootstrap && mkdir build && cd build && ../configure && make >> > 2. cd src/java/target/apidocs >> > 3. Open index.html in your browser. i.e. open index.html >> > 4. Verify the Executor API. >> > >> > >> > Thanks, >> > >> > Bernardo Gomez Palacio >> > >> > >> >> > -- Niklas
