----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21290/#review42736 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/21290/#comment76599> How about adding a header: // Successful registry operations. src/master/master.cpp <https://reviews.apache.org/r/21290/#comment76601> This is my fault, we should have a LOG(INFO) message after the CHECK here. How about we add it and move the metric incrementing up following the log message, as was done for _registerSlave and _reregisterSlave? LOG(INFO) << "Removed slave " << slaveInfo.id() << " (" << slaveInfo.hostname() << ")"; ++metrics.slave_removals; - Ben Mahler On May 9, 2014, 10:08 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21290/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 10:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1340 > https://issues.apache.org/jira/browse/MESOS-1340 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34 > > Diff: https://reviews.apache.org/r/21290/diff/ > > > Testing > ------- > > manual verification > > > Thanks, > > Dominic Hamon > >
