-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21388/#review42885
-----------------------------------------------------------

Ship it!


Thanks! Tested with command executor --override. Will publish a RR in a few.


3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21388/#comment76801>

    Won't some compilers complain about argc not being const here?


- Niklas Nielsen


On May 13, 2014, 1:14 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21388/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 1:14 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 70bd59c00fef0f4838634e85b5f35c374c671c2a 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 9d48c16f6de07854fda31163222db093d2f5346e 
> 
> Diff: https://reviews.apache.org/r/21388/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to