----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20292/#review42892 -----------------------------------------------------------
src/linux/routing/link/link.cpp <https://reviews.apache.org/r/20292/#comment76809> i'd simplify this to: if (link.isError()) { return Error(link.error()); } return link.isSome(); src/linux/routing/link/link.cpp <https://reviews.apache.org/r/20292/#comment76810> this could be: if (err == -NLE_EXIST) { return false; } return Error(nl_geterror(err)); src/linux/routing/link/link.cpp <https://reviews.apache.org/r/20292/#comment76811> this block is repeated a few times and might be worth abstracting. src/tests/routing_tests.cpp <https://reviews.apache.org/r/20292/#comment76812> has this been a problem? is some test not calling TearDown? - Dominic Hamon On May 12, 2014, 5:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20292/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 5:33 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > This is Part 1 of the linux routing library. > > > Diffs > ----- > > configure.ac 69acaa1 > src/Makefile.am 812ad2c > src/linux/routing/internal.hpp PRE-CREATION > src/linux/routing/link/internal.hpp PRE-CREATION > src/linux/routing/link/link.hpp PRE-CREATION > src/linux/routing/link/link.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20292/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
