----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21269/#review42894 -----------------------------------------------------------
src/linux/routing/utils.hpp <https://reviews.apache.org/r/21269/#comment76815> is this expected to be called in production code or just in tests? if the latter, please move it to the tests directly. src/tests/routing_tests.cpp <https://reviews.apache.org/r/21269/#comment76814> using '\n' is enough here unless you explicitly want to flush after every line. - Dominic Hamon On May 9, 2014, 3:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21269/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 3:27 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. We need this to check the capability of the underlying libnl > library. > > > Diffs > ----- > > src/Makefile.am f461a15 > src/linux/routing/utils.hpp PRE-CREATION > src/linux/routing/utils.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21269/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
