----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21176/#review42451 -----------------------------------------------------------
Patch looks great! Reviews applied: [21180, 21176] All tests passed. - Mesos ReviewBot On May 7, 2014, 11:05 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21176/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 11:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1319 and MESOS-1322 > https://issues.apache.org/jira/browse/MESOS-1319 > https://issues.apache.org/jira/browse/MESOS-1322 > > > Repository: mesos-git > > > Description > ------- > > This tests that: > > (1) Frameworks are notified of slaves that are lost across failovers. > (2) Slaves that are removed cannot re-register after a failover. > > > Diffs > ----- > > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 > > Diff: https://reviews.apache.org/r/21176/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh > --gtest_filter="MasterTest.RecoveredSlaveDoesNotReregister" > --gtest_repeat=150 --gtest_break_onailure --verbose > > > Thanks, > > Ben Mahler > >
