----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21249/#review42599 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/21249/#comment76411> Pull this up below _recover() because that was pulled up for the same reason :) src/tests/master_tests.cpp <https://reviews.apache.org/r/21249/#comment76412> Can you use the new style which is to call "createTask"? src/tests/master_tests.cpp <https://reviews.apache.org/r/21249/#comment76413> Kill this. I've moved/will move this comment to master.hpp. src/tests/master_tests.cpp <https://reviews.apache.org/r/21249/#comment76414> kill this? src/tests/master_tests.cpp <https://reviews.apache.org/r/21249/#comment76415> Can you be more specific? There is only one expectation, that of not receiving a status update, correct? - Vinod Kone On May 9, 2014, 12:06 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21249/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 12:06 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1321 > https://issues.apache.org/jira/browse/MESOS-1321 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34 > src/tests/master_tests.cpp 326392ed03f3cb1321ec21af57a5b0253cf29ef9 > > Diff: https://reviews.apache.org/r/21249/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
