> On May 13, 2014, 9:53 p.m., Dominic Hamon wrote: > > src/linux/routing/filter/internal.hpp, line 86 > > <https://reviews.apache.org/r/20781/diff/1/?file=569519#file569519line86> > > > > do these need to be inline in the header? consider adding them to a > > source file to reduce dependencies.
I would like to put all internal stuff in the same file:) > On May 13, 2014, 9:53 p.m., Dominic Hamon wrote: > > src/linux/routing/filter/internal.hpp, line 406 > > <https://reviews.apache.org/r/20781/diff/1/?file=569519#file569519line406> > > > > return cls.isSome(); Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20781/#review42895 ----------------------------------------------------------- On May 9, 2014, 10:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20781/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 10:27 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > Added internal APIs for filtering. This patch is used by the following > patches (ICMP, ARP, IP filters). All kinds of filters will use the same > internal APIs. > > In this patch, I also exposed APIs for queueing disciplines (qdisc) and > queueing classes. Currently, we only use the ingress queueing discipline for > packets redirection. In the future, we may wanna introduce different queueing > disciplines and classes for network isolation and shape control. The internal > APIs make the extension very easy. > > > Diffs > ----- > > src/Makefile.am d2e006d > src/linux/routing/filter/action.hpp PRE-CREATION > src/linux/routing/filter/filter.hpp PRE-CREATION > src/linux/routing/filter/internal.hpp PRE-CREATION > src/linux/routing/filter/priority.hpp PRE-CREATION > src/linux/routing/queueing/handle.hpp PRE-CREATION > src/linux/routing/queueing/handle.cpp PRE-CREATION > src/linux/routing/queueing/ingress.hpp PRE-CREATION > src/linux/routing/queueing/ingress.cpp PRE-CREATION > src/linux/routing/queueing/internal.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20781/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
