----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Bugs: MESOS-1278 https://issues.apache.org/jira/browse/MESOS-1278 Repository: mesos-git Description ------- Perf can be run against either a set of pids or a perf_event cgroup. I decided to parse the perf output into the protobuf directly, rather than via JSON, because it was simpler to handle output like <not supported> and <not counted>. Plus JSON's floating point numbers cannot fully represent uint64. Diffs ----- src/Makefile.am 12374c4a87836c160a7050c37ff7fec544b724e1 src/linux/perf.hpp PRE-CREATION src/linux/perf.cpp PRE-CREATION src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 src/tests/perf_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21443/diff/ Testing ------- Added tests for pids and cgroups. Thanks, Ian Downes