----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/#review42399 -----------------------------------------------------------
Bad patch! Reviews applied: [19966] Failed command: ./support/mesos-style.py Error: Checking 426 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/slave/containerizer/linux_launcher.hpp:61: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] Total errors found: 1 - Mesos ReviewBot On May 6, 2014, 7:34 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19966/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-1181 > https://issues.apache.org/jira/browse/MESOS-1181 > > > Repository: mesos-git > > > Description > ------- > > Enabled whitespace/blank_line rule for cpplint, which covers the following: > 'Redundant blank line at the start of a code block ' > 'should be deleted.' > 'Redundant blank line at the end of a code block ' > 'should be deleted.' > 'Do not leave a blank line after "public|protected|private:"' > '"class|struct:" should be preceded by a blank line' > > > Diffs > ----- > > src/common/resources.cpp 512dabf > src/slave/slave.cpp 2a48266 > src/tests/cluster.hpp 5dce50d > src/tests/isolator.hpp b1a3ac2 > src/tests/mesos.hpp 335b23a > support/mesos-style.py bd7dcdb > > Diff: https://reviews.apache.org/r/19966/diff/ > > > Testing > ------- > > Ran mesos-style.py over entire source base with whitespace/blank_line enabled. > $ support/mesos-style.py > Checking 424 files using filter > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo > Total errors found: 0 > > > Thanks, > > Adam B > >
