> On May 13, 2014, 12:27 a.m., Niklas Nielsen wrote: > > src/java/src/org/apache/mesos/MesosSchedulerDriver.java, lines 75-77 > > <https://reviews.apache.org/r/21080/diff/1/?file=574748#file574748line75> > > > > Would you mind ending the sentences with period '.'? > > Also, I feel like we should add a bit more context the the parameter > > descriptions. > > Below, you reference the framework as "framework data" and the master > > as "master identifier". Can we do it coherently and call it, for example " > > @param scheduler Scheduler implementation which callbacks are invoked > > upon scheduler events. > > @param framework FrameworkInfo describing the current framework. > > @param master The address to the currently active Mesos master. > > > > This is just a suggestion :) > >
Will do. - Bernardo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21080/#review42790 ----------------------------------------------------------- On May 13, 2014, 12:27 a.m., Bernardo Gomez Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21080/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 12:27 a.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1302 > https://issues.apache.org/jira/browse/MESOS-1302 > > > Repository: mesos-git > > > Description > ------- > > [MESOS-1259]:Enrich the Java Docs in the src/java files. -- > MesosSchedulerDriver.java > > > Diffs > ----- > > src/java/src/org/apache/mesos/MesosSchedulerDriver.java > 3fd1eb55468765cd9e9dceec53a653f6455000a3 > > Diff: https://reviews.apache.org/r/21080/diff/ > > > Testing > ------- > > 1. ./bootstrap && mkdir build && cd build && ../configure && make > 2. cd src/java/target/apidocs > 3. Open index.html in your browser. i.e. open index.html > 4. Verify the Executor API. > > > Thanks, > > Bernardo Gomez Palacio > >
