> On May 7, 2014, 3:51 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 24 > > <https://reviews.apache.org/r/21092/diff/1/?file=575452#file575452line24> > > > > Should the default be ? (or say, 1 hour) and people can specify a > > timeout as a query parameter? > > > > That way, people can just change the URL in order to tune this to their > > particular needs.
We could. I think we should have some sort of SLA about how quick we expect a response to be and use that as i default. I think 5 seconds is quite a long time already. Allowing users to choose to wait longer is a good idea. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21092/#review42434 ----------------------------------------------------------- On May 7, 2014, 9:19 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21092/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 9:19 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1287 > https://issues.apache.org/jira/browse/MESOS-1287 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > d5176ee4375febff26f52f167ead39a8303b54f9 > 3rdparty/libprocess/src/metrics/metrics.cpp > bb36c729532ce9a2ffad51d5b25e95355a78abad > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 9f04b9bff8f747176f009b3a9120521490bcc222 > > Diff: https://reviews.apache.org/r/21092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
