----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21257/ -----------------------------------------------------------
(Updated May 16, 2014, 2:02 a.m.) Review request for mesos and Vinod Kone. Changes ------- Corrected commit amending I forgot to strip the output of executing the post command. The output of post-review has the last line being the review url. The difference between the output of rbt and post-review is that rbt has it on the second to the last line with the last line being the diff url(e.g. https://reviews.apache.org/r/21545/diff) instead. I've made changes so that the amended commit whether we use post-review or rbt is identical, both using the standard review url. (e.g. https://reviews.apache.org/r/21545) Bugs: MESOS-1333 https://issues.apache.org/jira/browse/MESOS-1333 Repository: mesos-git Description ------- 1) Initially I was trying to use the post-reviews.py script to see if I could create a review request since I never got post review installed and figured out. When I ran the program I ran into an exception when execute was called which was because the command was accidentally passed in as two separate arguments rather than a list of two arguments. 2) Next, since I was using rbt 0.6 I ran into an issue where the revision range was not a supported parameter anymore since it was previously deprecated. I've updated the way the command is built and considered if we are using rbt or post-review. Diffs (updated) ----- support/post-reviews.py 0ba14d8 Diff: https://reviews.apache.org/r/21257/diff/ Testing ------- ./support/post-reviews.py Thanks, Steven Phung
