----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21182/#review42523 -----------------------------------------------------------
Ship it! I have drawn out the call sequences for the "recursion via .then" in create() and it looks good! Libprocessifying ZooKeeperImpl -> ZooKeeperProcess solves two problems we have: 1. Watcher events coming in too soon during ZooKeeper object construction. 2. Watcher events coming in too late during (racing with) Zookeeper object destruction (due to local timeout) This patch looks great to me! - Jiang Yan Xu On May 7, 2014, 5:56 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21182/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 5:56 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-1318 > https://issues.apache.org/jira/browse/MESOS-1318 > > > Repository: mesos-git > > > Description > ------- > > Yan Xu and I paired on this. See > https://issues.apache.org/jira/browse/MESOS-1318 for more details. > > > Diffs > ----- > > src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e > src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 > > Diff: https://reviews.apache.org/r/21182/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
