> On May 16, 2014, 7:19 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, line 836 > > <https://reviews.apache.org/r/21424/diff/2/?file=583558#file583558line836> > > > > What does according to the internal states mean? > > Till Toenshoff wrote: > It means that the EC does not have any knowledge on such container ever > being launched - usually an indicator for an orphan, as discussed before. > > Your comment hints that I should rephrase. > > How about: > LOG(WARNING) << "Container '" << containerId << "' not running according > to the slave states."; ?
Why are we logging the same thing inside destroy, _destroy, and __destroy? The current log messages here seem like they may be a bit confusing for those reading the logs. We should have some logging that says what we're doing. In 'destroy', we could either say: INFO: "Destroying container ID", or INFO: "Attempting to destroy unknown container ID" We can make the second case a WARNING but it's expected that we'll encounter orphans. In '__destroy', we could say say: INFO: "Destroyed container ID" What happens when in between 'destroy' and '_destroy', the 'launched->future()' never completes? Should there be a timeout to proceed with destruction? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/#review43244 ----------------------------------------------------------- On May 16, 2014, 7:20 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21424/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 7:20 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1364 > https://issues.apache.org/jira/browse/MESOS-1364 > > > Repository: mesos-git > > > Description > ------- > > An orphaned container is known to the ECP but not to the EC, thus not > recoverable but pending. This patch enforces a call to destroy for any orphan > that has been identified as such during the recovery phase. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.hpp afffff1 > src/slave/containerizer/external_containerizer.cpp 2ff19b1 > > Diff: https://reviews.apache.org/r/21424/diff/ > > > Testing > ------- > > make check (note that the tests currently do not cover this scenario) > > > Thanks, > > Till Toenshoff > >
