> On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 18 > > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line18> > > > > New file that you're missing from this diff?
that was done in a dependent review. but one of the review updates removed the "depends on" field :/. will reset it. > On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 65 > > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line65> > > > > Maybe grab std::map along with std::string while you're at it? done. > On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 555 > > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line555> > > > > I'm guessing TemporaryDirectoryTest defined in the missing utils.hpp? see my first reply. > On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 580 > > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line580> > > > > What's 'tmpdir'? Perhaps it's exposed in the mysterious > > TemporaryDirectoryTest? We didn't expose 'tmpdir' in Mesos but instead used > > os::getcwd() for stuff like this. see above. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21565/#review43402 ----------------------------------------------------------- On May 19, 2014, 9:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21565/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 9:28 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1344 > https://issues.apache.org/jira/browse/MESOS-1344 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > a781f14aec9dc5b6350d8e5452a7131cbb891595 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48 > > Diff: https://reviews.apache.org/r/21565/diff/ > > > Testing > ------- > > stout make check > > > Thanks, > > Vinod Kone > >
