----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21665/#review43495 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/21665/#comment77654> is it worth differentiating between the future failing and the future being ready but not having a valid principal? src/sasl/authenticator.hpp <https://reviews.apache.org/r/21665/#comment77655> s/static_cast/reinterpret_cast/ std::string(input, inlen); CHECK_NOTNULL(input); CHECK_NOTNULL(principal); CHECK_NOTNULL(output); maybe also: Option<std::string>* principal = reinterpret_cast<Option<std::string>*>(_principal); CHECK_NONE(*principal); src/sasl/authenticator.hpp <https://reviews.apache.org/r/21665/#comment77656> unnecessary as this defaults to None(). src/sasl/authenticator.hpp <https://reviews.apache.org/r/21665/#comment77658> this seems fragile.. could it be a std::vector<sasl_callback_t> instead? - Dominic Hamon On May 19, 2014, 3:09 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21665/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 3:09 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1383 > https://issues.apache.org/jira/browse/MESOS-1383 > > > Repository: mesos-git > > > Description > ------- > > The principal returned from Authenticator will be useful in a next patch for > https://issues.apache.org/jira/browse/MESOS-1373 > > > Diffs > ----- > > src/master/master.hpp 25d9e837198ffed60c445e21de4ba0cba49106f0 > src/master/master.cpp 63b6cdc9634608ac730de7194fb8ed0baadb9a77 > src/sasl/authenticator.hpp 784ecc876bef236fdf6b83ac118c5e7e4a02f156 > src/tests/sasl_tests.cpp 945426d899e0e3c8cc32f494f26a0103f610ddc6 > > Diff: https://reviews.apache.org/r/21665/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
