----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21783/#review43649 -----------------------------------------------------------
Ship it! src/zookeeper/zookeeper.cpp <https://reviews.apache.org/r/21783/#comment77931> No big deal but why not Timeout::in(timeout) and Timeout::expired()? src/zookeeper/zookeeper.cpp <https://reviews.apache.org/r/21783/#comment77932> Do we want to put a log line here? This may look redundant because of the ZK log but ZK logs are less clear and its log level may be independently adjusted. - Jiang Yan Xu On May 21, 2014, 11:52 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21783/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 11:52 a.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-1326 > https://issues.apache.org/jira/browse/MESOS-1326 > > > Repository: mesos-git > > > Description > ------- > > Often during temporary DNS failovers or outages, we see slaves aborting in > zookeeper_init. > > In many cases, the slave can restart within 10 seconds. Since retrying > zookeeper_init should be safe to do, this is an attempt to minimize the > number of unnecessary aborts in the slave. > > > Diffs > ----- > > src/zookeeper/zookeeper.cpp 11029be89bd184dbefe103c84239c1c6b03e3e10 > > Diff: https://reviews.apache.org/r/21783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
