----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21680/#review43695 -----------------------------------------------------------
Ship it! src/slave/containerizer/external_containerizer.hpp <https://reviews.apache.org/r/21680/#comment77996> 2 spaces more. We don't really follow the Google C++ style guide here, but you can check constructors in for example slave.cpp for reference. src/slave/containerizer/external_containerizer.hpp <https://reviews.apache.org/r/21680/#comment77995> "Is set when container is being destroyed"? src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21680/#comment77994> How about "Container '" << containerId << "' is already being destroyed"? Also, remove the trailing period in log messages :) - Niklas Nielsen On May 19, 2014, 8:23 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21680/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 8:23 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.hpp afffff1 > src/slave/containerizer/external_containerizer.cpp f9811c4 > > Diff: https://reviews.apache.org/r/21680/diff/ > > > Testing > ------- > > make check (on upcoming EC test suite) > > > Thanks, > > Till Toenshoff > >
