> On May 22, 2014, 3:44 a.m., Niklas Nielsen wrote: > > Super cool Tim! The code looks great but would love to see a test for this > > :) Should be doable for local files, but let's sync up if you need some > > input on how to get going.
That was originally the plan :) However I know Bernd created a nice framework for fetcher test for the feature he's working on, so I was thinking to use what he did. Chatted with Adam and thought I'll just post this first and see as it's not a big change. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review43700 ----------------------------------------------------------- On May 22, 2014, 3:29 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 3:29 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/launcher/fetcher.cpp 8c9e20d > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
