----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21837/#review43856 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/21837/#comment78129> lets to startsWith("master") to be future proof. we might actually want to use UUIDs in pids at some point to tackle cases that you described above. - Vinod Kone On May 23, 2014, 5:07 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21837/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 5:07 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1411 > https://issues.apache.org/jira/browse/MESOS-1411 > > > Repository: mesos-git > > > Description > ------- > > This is part 1 of MESOS-1411. > > This ensures that the slave can handle an acknowledgement that comes from the > master, while still handling updates coming directly from the scheduler > driver. > > I added a check that ignores acknowledgement that arrive while the slave is > not registered. Ideally we would ensure that we also don't *send* status > updates while we're not registered, but I've left that as is for now > (MESOS-1414). > > > Diffs > ----- > > src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e > src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7 > src/tests/status_update_manager_tests.cpp > 8cbfb83b2ef1ecbdcb91a81aa727a3b58009a3f6 > > Diff: https://reviews.apache.org/r/21837/diff/ > > > Testing > ------- > > Tests were added in r/21838. > > > Thanks, > > Ben Mahler > >
