----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21677/#review43873 -----------------------------------------------------------
Ship it! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21677/#comment78151> Can you be more precise here? It's great that you reference the JIRA, but the real issue is that containerizer(s) (so far) has relied on state being persisted in the slave. However, that responsibility should have been delegated to the containerizer too? - Niklas Nielsen On May 19, 2014, 7:09 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21677/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 7:09 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > The slave currently expects a forked executor PID within its states when > recovering. For the ExternalContainerizer however this does not make sense > but is introduced in this patch to get around the problem as described in > MESOS-1328 and MESOS-923. This patch can entirely be dropped if a fix for the > mentioned tickets comes in first. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp f9811c4 > > Diff: https://reviews.apache.org/r/21677/diff/ > > > Testing > ------- > > make check (in upcoming EC test suite) > > > Thanks, > > Till Toenshoff > >
