> On May 23, 2014, 6:47 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 1455 > > <https://reviews.apache.org/r/21838/diff/1/?file=589227#file589227line1455> > > > > s/acknowledgementMessage/statusUpdateAcknowledgementMessage/
This one makes the code pretty verbose as a number of things end up flowing onto multiple lines. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21838/#review43861 ----------------------------------------------------------- On May 23, 2014, 5:07 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21838/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 5:07 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1411 > https://issues.apache.org/jira/browse/MESOS-1411 > > > Repository: mesos-git > > > Description > ------- > > This is part 2 of MESOS-1411. > > This ensures that the master can handle status update acknowledgement > messages coming from the scheduler driver. For now, it simply forwards these > on to the slaves. Later we will update the master to rely the acknowledgement > messages to remove tasks from its memory (MESOS-1410). > > > Diffs > ----- > > src/master/master.hpp 99c70631ba10e8811ab0011881f30134c4d0373c > src/master/master.cpp e5d8edf4db932e2c48756df67750b02bbff59c55 > src/tests/master_tests.cpp b0e05de9a7226ee330007a3f3fe71976fb0748d6 > src/tests/slave_tests.cpp 85ca5c41bfafe4f932ea51b4fb9654b2fc828232 > > Diff: https://reviews.apache.org/r/21838/diff/ > > > Testing > ------- > > Added two tests here: > > (1) Send the acknowledgement through the Master by intercepting it when it > leaves the driver. > > (2) Ensure the slave ignores an acknowledgement from a non-leading master. > > Ran each test with 1000 iterations. > > > Thanks, > > Ben Mahler > >
