----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21948/#review44065 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/21948/#comment78378> drive-by thought: instead of a boolean parameter that requires a comment, would a separate method 'rescindOffer' or an enum with RESCIND/NO_RESCIND values be more readable? - Dominic Hamon On May 27, 2014, 3:51 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21948/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 3:51 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1419 > https://issues.apache.org/jira/browse/MESOS-1419 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 21472e94658be6e31f13eacc5412144d62b12096 > > Diff: https://reviews.apache.org/r/21948/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
