----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20987/#review44071 -----------------------------------------------------------
Patch looks great! Reviews applied: [20987] All tests passed. - Mesos ReviewBot On May 15, 2014, 6:04 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20987/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 6:04 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1285 > https://issues.apache.org/jira/browse/MESOS-1285 > > > Repository: mesos-git > > > Description > ------- > > see summary > > this will become important when we start adding metrics to Process as we'll > use the generated id which might include ()s. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metric.hpp > 00ace49bc5ef3914704c6247ece99474444960c9 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/20987/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
