[
https://issues.apache.org/jira/browse/MESOS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010687#comment-14010687
]
ASF GitHub Bot commented on MESOS-878:
--------------------------------------
GitHub user yifan-gu opened a pull request:
https://github.com/apache/mesos/pull/18
Fix issue #878
Added a sentence to check the slave's state in doReliableRegistration() to
make sure that the function returns when the slave's state is TERMINATING.
See https://issues.apache.org/jira/browse/MESOS-878
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yifan-gu/mesos issue-878
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 4efc720e5305080bec2c43930ed24a128c94d644
Author: Yifan Gu <[email protected]>
Date: 2014-05-28T02:18:08Z
Added NO_FUTURE_PROTOBUFS and NO_FUTURE_MESSAGES
Added NO_FUTURE_MESSAGES in gmock.hpp
Added NO_FUTURE_PROTOBUFS in tests/mesos.hpp
commit 4d617e1a68f99d86af4f199da35055d39a9890ff
Author: Yifan Gu <[email protected]>
Date: 2014-05-28T02:26:15Z
fix(slave): doReliableReliableRegistration
Eliminate unnecessary repeated re-registrations when the slave
is terminating.
----
> Slave should not register with the master when in TERMINATING.
> --------------------------------------------------------------
>
> Key: MESOS-878
> URL: https://issues.apache.org/jira/browse/MESOS-878
> Project: Mesos
> Issue Type: Bug
> Reporter: Benjamin Mahler
> Assignee: Yifan Gu
>
> If the slave takes a long time to shut down, doReliableRegistration in the
> slave will continue to re-register (causing the master to re-add the slave)
> and the slave will continue to drop the re-registration acknowledgement
> messages since it is in the TERMINATING state.
> The slave should not attempt to register when it is in a TERMINATING state.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
