----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19545/#review44154 -----------------------------------------------------------
I see this is already submitted, just noticed a few things we should follow up on below. 3rdparty/libprocess/include/process/system.hpp <https://reviews.apache.org/r/19545/#comment78476> How about including the error messages in these strings? "Failed to get loadavg: " + load.error() Also, please don't end these with periods :) 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment78481> Was the diff bad here? Why all the changes to this test? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment78480> :( why did we make the test more complicated in this review? Was the JSON equality insufficient? Isn't this unrelated to this change? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment78478> s/std::// 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment78479> s/std::// - Ben Mahler On May 27, 2014, 5:49 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19545/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 5:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1146 > https://issues.apache.org/jira/browse/MESOS-1146 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am fa9b4fd0bb2555c3372151f8b86c8a6457319d93 > 3rdparty/libprocess/include/process/system.hpp > fbd1eaa1de44eb419cef4c78efd6d138eabc7b44 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > 3rdparty/libprocess/src/tests/system_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19545/diff/ > > > Testing > ------- > > make check and manually checked /system/stats.json against /metrics > > > Thanks, > > Dominic Hamon > >
