----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21950/#review44171 -----------------------------------------------------------
Ship it! Just a couple of wording suggestions. Take them or leave them. configure.ac <https://reviews.apache.org/r/21950/#comment78494> Suggested addition: "... correctly installed and added to your PATH, or ..." since a correct installation may not necessarily mean that it exists on PATH. configure.ac <https://reviews.apache.org/r/21950/#comment78492> "... or set the MAVEN_HOME environment variable to point to your Maven installation." configure.ac <https://reviews.apache.org/r/21950/#comment78491> Suggested alternate wording: "Please verify that MAVEN_HOME points to the root of a valid Maven installation." - Adam B On May 27, 2014, 7:43 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21950/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 7:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Bugs: MESOS-1290 > https://issues.apache.org/jira/browse/MESOS-1290 > > > Repository: mesos-git > > > Description > ------- > > Verbose Maven error on configure > > > Diffs > ----- > > configure.ac 1ebd196 > > Diff: https://reviews.apache.org/r/21950/diff/ > > > Testing > ------- > > ./boostrap on a machine without maven installed > mkdir build > cd build > ../configure > check for a message more verbose than 'can not find mvn on your path' > export MAVEN_HOME="something" > check for message more verbose than 'can not find mvn inside /bin/something' > > > Thanks, > > Isabel Jimenez > >
