----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21961/#review44191 -----------------------------------------------------------
Ship it! Looks a bit easier to understand than before, great! Ditto Adam's comment about moving the expectation down in the test. - Ben Mahler On May 28, 2014, 2:14 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21961/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 2:14 a.m.) > > > Review request for mesos, Adam Berry, Benjamin Hindman, and Ben Mahler. > > > Bugs: MESOS-1418 > https://issues.apache.org/jira/browse/MESOS-1418 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp f0490ec639d5c1f73ee5754bcca445daa9499caf > src/master/master.cpp 21472e94658be6e31f13eacc5412144d62b12096 > src/tests/fault_tolerance_tests.cpp > 3f2639347c7fde1b1b8e3c976e493b5fa2c3ade2 > > Diff: https://reviews.apache.org/r/21961/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
