> On April 14, 2014, 6 p.m., Dominic Hamon wrote: > > include/mesos/scheduler.hpp, line 455 > > <https://reviews.apache.org/r/20309/diff/1/?file=555864#file555864line455> > > > > please use lambda::function here to avoid more c++11-only code paths.
I can't use 'lambda' here as stout is not a "public" API. > On April 14, 2014, 6 p.m., Dominic Hamon wrote: > > include/mesos/mesos.proto, line 497 > > <https://reviews.apache.org/r/20309/diff/1/?file=555863#file555863line497> > > > > this might be cleaner if the messages aren't nested. As it is, it's > > tough to read and reason about. > > > > Or maybe it's just a matter of putting all the nested types first and > > then the fields? > > > > Did you consider the 'Nested Extensions' method: > > http://www.indelible.org/ink/protobuf-polymorphism/ ? The "nested extensions" stuff is quite a bit more complicated than the standard "union" trick that I'm doing here (Google even has a page describing it: https://developers.google.com/protocol-buffers/docs/techniques#union). I moved all the fields to the bottom though. I like it better too! Thanks for the suggestion. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20309/#review40279 ----------------------------------------------------------- On June 3, 2014, 3:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20309/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:57 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > See summary. Note that in an incremental review I plan to implement Scheduler > and SchedulerDriver on this API so that we can run all existing tests using > this API. For now I've included at least one test as a demonstration. > > > Diffs > ----- > > include/mesos/mesos.proto 82388e1ed5ee36aaf7fc31d7a59aa0923ee9ab46 > include/mesos/scheduler.hpp 85db1117122441b5d9fb013380ea37aa0acc84ea > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014 > src/scheduler/scheduler.cpp PRE-CREATION > src/tests/master_tests.cpp 7183cb7d567664a2f07b8d11980c8fbbec1711af > src/tests/scheduler_tests.cpp bd3c22d5a500c6f9046afa5ff5185a4d86796c57 > > Diff: https://reviews.apache.org/r/20309/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
