----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20308/#review44676 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/queue.hpp <https://reviews.apache.org/r/20308/#comment79131> Shouldn't this be a queue of T's as opposed to a queue of Futures? Looks like there are only ever completed futures in the queue and we can avoid the extra copies from using Future. - Ben Mahler On June 3, 2014, 3:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20308/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:57 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am b687068b543947ab05482f5f34d982e017323007 > 3rdparty/libprocess/include/process/queue.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/queue_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20308/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
