----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22162/#review44770 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/22162/#comment79313> What is the longer term strategy for message validation? Having a single generically named 'validate' suggests a large number of overloads or other handlers? Isn't 'validate' a bit too generic for only validating framework registration and re-registration? Probably we should think carefully about how we want to do message validation in a more general sense in the master. - Ben Mahler On June 3, 2014, 3:30 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22162/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:30 p.m.) > > > Review request for mesos, Adam B, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1373 > https://issues.apache.org/jira/browse/MESOS-1373 > > > Repository: mesos-git > > > Description > ------- > > This is a follow up for https://reviews.apache.org/r/21787. > There exists duplication of logic in (re)-registerFramework methods. > > > Diffs > ----- > > src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1 > src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719 > > Diff: https://reviews.apache.org/r/22162/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
