----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22266/#review44836 -----------------------------------------------------------
Ship it! Looks good - thanks! Do we still want to maintain the overloaded launchTasks() in the scheduler APIs (Java, Python, ...)? - Niklas Nielsen On June 5, 2014, 10:35 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22266/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 10:35 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1451 > https://issues.apache.org/jira/browse/MESOS-1451 > > > Repository: mesos-git > > > Description > ------- > > The scheduler driver has been using the new 'offer_ids' field since 0.18.0 so > we should follow up and remove the deprecated 'offer_id' field. This > simplifies the master logic and the driver logic. > > > Diffs > ----- > > src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1 > src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94 > src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4 > src/sched/sched.cpp b27222e806387ea18ef37584e2626974c665fa0b > > Diff: https://reviews.apache.org/r/22266/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
