----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22253/#review44944 -----------------------------------------------------------
Ship it! It looks good to me. - Jie Yu On June 4, 2014, 11:37 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22253/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 11:37 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1417 > https://issues.apache.org/jira/browse/MESOS-1417 > > > Repository: mesos-git > > > Description > ------- > > Wait on Containerizer::update to complete before sending status update. > > If the update fails the container will be destroyed. > > > Diffs > ----- > > src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62 > src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 > src/tests/status_update_manager_tests.cpp > c753921194a3ae449feff0b20dfc058b6e086528 > > Diff: https://reviews.apache.org/r/22253/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
