----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22267/#review44955 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On June 5, 2014, 5:35 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22267/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 5:35 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-1453 > https://issues.apache.org/jira/browse/MESOS-1453 > > > Repository: mesos-git > > > Description > ------- > > Currently, we only reply to a reconciliation request when the task state > differs. This makes it difficult for a framework to implement reconciliation: > if the framework does not receive an update for the task, it cannot determine > if this was because the state is valid, or the slave was transitioning, or > the master has not recovered yet. > > As a consequence of this, frameworks looking to reconcile tasks need to > continually retry at small intervals to compensate for the lack of ability to > differentiate the cases listed above. > > If we always send back the latest status for each task requested, then the > frameworks can more easily implement reconciliation. > > > Diffs > ----- > > include/mesos/scheduler.hpp a17db5919f8c434a918bf5f782ef5e02c5a9be9c > src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94 > src/tests/reconciliation_tests.cpp 677d18e1a4e1683809d21eb96bab48d6e3868207 > > Diff: https://reviews.apache.org/r/22267/diff/ > > > Testing > ------- > > Modified the tests. > > > Thanks, > > Ben Mahler > >
