----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22353/#review45097 -----------------------------------------------------------
Lets hold off on this refactor. This code is currently under refactor per my earlier review: https://reviews.apache.org/r/22151/ - Vinod Kone On June 8, 2014, 4:29 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22353/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 4:29 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Niklas Nielsen, and Vinod > Kone. > > > Repository: mesos-git > > > Description > ------- > > Refactored on Master::launchTasks: > Extracted the offer validation and task validation logic, so that other > modules can reuse the code.(e.g. resize tasks). > Put valid tasks in a ready queue after validation. > Modified on ExecutorInfoChecker to support above. > Changed Master::launchTask's interface from (const TaskInfo&, const > Framework*, const Slave*) > to (const TaskInfo&, const FrameworkID&, const SlaveID&). > > > Diffs > ----- > > src/master/master.hpp e244831 > src/master/master.cpp 89f426c > > Diff: https://reviews.apache.org/r/22353/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yifan Gu > >
