-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21316/#review45177
-----------------------------------------------------------
Bad patch!
Reviews applied: [21316]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
In file included from ../../src/launcher/fetcher.cpp:30:0:
../../src/slave/containerizer/mesos_fetcher.hpp:131:34: sorry, unimplemented:
non-static data member initializers
../../src/slave/containerizer/mesos_fetcher.hpp:131:34: error: ISO C++ forbids
in-class initialization of non-const static member 'referenceCount'
../../src/slave/containerizer/mesos_fetcher.hpp:171:35: sorry, unimplemented:
non-static data member initializers
../../src/slave/containerizer/mesos_fetcher.hpp:171:35: error: ISO C++ forbids
in-class initialization of non-const static member 'cacheFileSerial'
../../src/slave/containerizer/mesos_fetcher.hpp:177:31: error: invalid use of
non-static data member 'mesos::internal::slave::MesosFetcher::generationA'
../../src/slave/containerizer/mesos_fetcher.hpp:182:51: error: from this
location
../../src/slave/containerizer/mesos_fetcher.hpp:182:51: sorry, unimplemented:
non-static data member initializers
../../src/slave/containerizer/mesos_fetcher.hpp:182:51: error: 'constexpr'
needed for in-class initialization of static data member 'youngGeneration' of
non-integral type
../../src/slave/containerizer/mesos_fetcher.hpp:178:31: error: invalid use of
non-static data member 'mesos::internal::slave::MesosFetcher::generationB'
../../src/slave/containerizer/mesos_fetcher.hpp:186:49: error: from this
location
../../src/slave/containerizer/mesos_fetcher.hpp:186:49: sorry, unimplemented:
non-static data member initializers
../../src/slave/containerizer/mesos_fetcher.hpp:186:49: error: 'constexpr'
needed for in-class initialization of static data member 'oldGeneration' of
non-integral type
make[3]: *** [launcher/mesos_fetcher-fetcher.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On June 9, 2014, 10:56 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21316/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 10:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-336
> https://issues.apache.org/jira/browse/MESOS-336
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The first cut at fetcher caching. See MESOS-336 JIRA for explanation for this
> approach: keep the cache info in the MesosContainerizerProcess in the save,
> leverage actor single-threadedness to deal with concurrency issues without
> head ache.
>
> Features so far:
> - If URI flag "fetched_externally" (default: false) is set, the fetcher does
> what it did in Mesos 0.18 and before.
> - If URI flag "cached" (default: false) is not set, the fetcher also fetches
> every time as in Mesos 0.18 and before.
> - If URI flag "cached" is set, the UIR is only fetched once and all
> subsequent fetch attempts copy from the cache file.
> - URIs are cached separately per framework (ID).
> - Recovery is implemented by simply wiping the entire cache.
> - GC for cache files. Global flag sets lifetime after last use. Default is 1
> hour.
>
> Potential future features:
> - symlinks instead of copying
> - extraction directly from URI, without cache file
> - combine that with symlinks
> - Refreshing, explicit cache invalidation
> - ...
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
> include/mesos/scheduler.hpp d224945
> src/Makefile.am 4a3f2e1
> src/launcher/fetcher.cpp c4425eb
> src/local/local.cpp 5d26aff
> src/slave/constants.hpp ace4590
> src/slave/constants.cpp 51f65bb
> src/slave/containerizer/mesos_containerizer.hpp 1f5908a
> src/slave/containerizer/mesos_containerizer.cpp 1438024
> src/slave/containerizer/mesos_fetcher.hpp PRE-CREATION
> src/slave/containerizer/mesos_fetcher.cpp PRE-CREATION
> src/slave/flags.hpp 15e5b64
> src/slave/slave.hpp 34687e5
> src/slave/slave.cpp 643c088
> src/tests/containerizer_tests.cpp 8ea7974
> src/tests/fetcher_tests.cpp PRE-CREATION
> src/tests/slave_tests.cpp 2c8f183
>
> Diff: https://reviews.apache.org/r/21316/diff/
>
>
> Testing
> -------
>
> Tests have been written, have been run successfully, and are included in the
> patch.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
