----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22190/#review45282 -----------------------------------------------------------
Ship it! src/tests/master_authorization_tests.cpp <https://reviews.apache.org/r/22190/#comment80041> Should all these comments be updated now to say '_launchTasks()'? Might make it clearer to see that's it is about the continuation not being executed yet. src/tests/master_authorization_tests.cpp <https://reviews.apache.org/r/22190/#comment80043> Could the names of all these 'future' objects be updated to 'authorize'? Might make it a bit easier to read. src/tests/master_authorization_tests.cpp <https://reviews.apache.org/r/22190/#comment80045> Is this comment accurate? We can't send TASK_LOST if the framework is removed and the test doesn't seem to be looking for that either? src/tests/master_authorization_tests.cpp <https://reviews.apache.org/r/22190/#comment80046> Seems like we could also have the authorization go through and wait for the launch, instead of settling the clock? Up to you. src/tests/mesos.hpp <https://reviews.apache.org/r/22190/#comment80038> Ahh, this is why we always have allocator expectation messages in the test.. I see the MockAllocatorProcess is still using ON_CALL. =/ - Ben Mahler On June 10, 2014, 6:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22190/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:28 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1114 > https://issues.apache.org/jira/browse/MESOS-1114 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/cluster.hpp f4cc9a62cd0ca86cd87987d963abd951a377ddd1 > src/tests/master_authorization_tests.cpp PRE-CREATION > src/tests/mesos.hpp 2e01e5e08c57b26ea20a4dfe3613fe548ae7adf5 > src/tests/mesos.cpp ea6a1c013dcc1d76e05ac0126e90f3cf16478790 > > Diff: https://reviews.apache.org/r/22190/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
