> On June 11, 2014, 12:27 a.m., Ben Mahler wrote: > > src/tests/script.cpp, lines 136-137 > > <https://reviews.apache.org/r/22447/diff/1/?file=606897#file606897line136> > > > > Move this above the write call? > > Vinod Kone wrote: > I like the comment on top of the block pertaining to ACLs because it is > all part of ACLs creation, similar to what we did with Credentials.
I was referring to the path variable (used only for the os::write call) rather than the comment. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22447/#review45318 ----------------------------------------------------------- On June 11, 2014, 12:55 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22447/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 12:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Re-enabled "--acls" flag on master and updated example tests to use > authorization. > > > Diffs > ----- > > src/master/flags.hpp ed08c6b9d317fb87ccefa1235f405c5238578188 > src/tests/script.cpp e5885eedb84838b2e774f313679392b95a0a1169 > src/tests/test_framework_test.sh a521b4713b2b63d2cf5d8422234d913063e3b485 > > Diff: https://reviews.apache.org/r/22447/diff/ > > > Testing > ------- > > make check GTEST_FILTER="*Examples*" > > > Thanks, > > Vinod Kone > >
