----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22064/#review45396 -----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/22064/#comment80231> Ditto BenM's comments. I think having a destroyTimedout in the library is a bit strange. I guess the reason is because you have a lot of duplication here because the action after destroy timedout is the same. If that's the case, I would rather add an overload for cgroups::destory which takes a timeout value, and invoke the existing non-timeout version of the cgroups::destroy. (Although we try to avoid having timeout in library as much as possible). What do you think? - Jie Yu On June 11, 2014, 5:27 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22064/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 5:27 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Use a timeout to discard cgroups::destroy. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 909ea8802b3746b73aae8d62c8e49f259c471fd5 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 3d253af51677dcb4dc48dc9e01bdc2ba80847da9 > src/slave/containerizer/isolators/cgroups/mem.hpp > 362ebcfa2e16701b225deea0fbeb92e4a56d51aa > src/slave/containerizer/isolators/cgroups/mem.cpp > 60013d4e840f6b1f131b796b95916d1978b37c70 > src/slave/containerizer/linux_launcher.cpp > c17724b138de9d64856fb85db019e52043fbc7af > > Diff: https://reviews.apache.org/r/22064/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
