-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21451/#review45454
-----------------------------------------------------------
Bad patch!
Reviews applied: [21442, 20963, 21451]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
zip_safe flag not set; analyzing archive contents...
In file included from
../../src/slave/containerizer/mesos_containerizer.cpp:48:0:
../../src/slave/containerizer/isolators/cgroups/perf_event.hpp:24:26: fatal
error: linux/perf.hpp: No such file or directory
compilation terminated.
make[3]: ***
[slave/containerizer/libmesos_no_3rdparty_la-mesos_containerizer.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On June 11, 2014, 5:29 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21451/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 5:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1278
> https://issues.apache.org/jira/browse/MESOS-1278
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Three new slave flags:
> 1. perf_events is a list of perf events to sample. This list is validated
> through perf during isolation creation.
> 2. perf_interval is the time between starting new samples
> 3. perf_duration is the duration of each sample
>
> e.g., you could sample cpu-cycles and cpu-migrations for 10 seconds every 60
> seconds.
>
> Isolator::usage() will initially return an empty PerfStatistics protobuf
> (containing only the timing information) until the first sample is obtained.
> After that it will return the most recent sample.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION
> src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION
> src/slave/containerizer/mesos_containerizer.cpp
> 14380240512d29b49c2e8f2831a9ef8ca102a024
> src/slave/flags.hpp 15e5b64fd24a9381074b4833a0403314e1f404bc
> src/tests/isolator_tests.cpp b0eff5721b6ea4dcee8ff3748a2a11ade809e30e
> src/tests/mesos.cpp ea6a1c013dcc1d76e05ac0126e90f3cf16478790
> src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b
>
> Diff: https://reviews.apache.org/r/21451/diff/
>
>
> Testing
> -------
>
> tests:
> 1. sampling of the perf event isolator
> 2. slave recovery for roll forward
>
>
> Thanks,
>
> Ian Downes
>
>
