----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22223/#review45468 -----------------------------------------------------------
Patch looks great! Reviews applied: [22223] All tests passed. - Mesos ReviewBot On June 11, 2014, 7:34 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22223/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 7:34 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone. > > > Bugs: MESOS-1312 > https://issues.apache.org/jira/browse/MESOS-1312 > > > Repository: mesos-git > > > Description > ------- > > Added orphan_tasks and unknown_frameworks in state.json to display tasks that > are currently running on the slaves, > but do not belong to any already (re-)registered frameworks. > > > Diffs > ----- > > src/master/http.cpp b565dc6 > src/tests/master_tests.cpp 34df121 > > Diff: https://reviews.apache.org/r/22223/diff/ > > > Testing > ------- > > Added MasterTest.OrphanTasks to test: > 1, Before the framework re-registers with the master: > Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] > field. > That frameworks will appear in the ["not_yet_reregistered_frameworks"] > field. > 2, After the framework re-registers with the master: > There will be no more orphan tasks and not-yet-reregistered frameworks. > 3, Havent' do the WebUI js part. > > > Thanks, > > Yifan Gu > >
