-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22472/#review45516
-----------------------------------------------------------


I think the subject is a bit off, should say "Reregister", not "Register", 
right?

Did you run this with repetition to see if it is flaky still?

$ ./bin/mesos-tests.sh 
--gtest_filter="SlaveTest.TerminatingSlaveDoesNotReregister" --gtest_repeat=-1 
--gtest_break_on_failure --verbose

- Ben Mahler


On June 11, 2014, 7:18 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22472/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 7:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Bugs: MESOS-1460
>     https://issues.apache.org/jira/browse/MESOS-1460
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ignored subsequent status updates.
> Muted warnings by catching mock calls.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 2c8f183 
> 
> Diff: https://reviews.apache.org/r/22472/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>

Reply via email to