----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20818/#review45587 -----------------------------------------------------------
Bad patch! Reviews applied: [20817, 20818] Failed command: ./support/mesos-style.py Error: Checking 470 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/linux/cgroups.cpp:1431: Do not leave a blank line after "private:" [whitespace/blank_line] [3] Total errors found: 1 - Mesos ReviewBot On June 12, 2014, 5:24 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20818/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 5:24 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-759 and MESOS-976 > https://issues.apache.org/jira/browse/MESOS-759 > https://issues.apache.org/jira/browse/MESOS-976 > > > Repository: mesos-git > > > Description > ------- > > internal::Destroyer now uses a single pass of freeze, kill, thaw, reap > to kill all processes in a freezer cgroup. cgroups::destroy will not > complete until all processes have been reaped. A timeout is used for > each step so destroy will eventually fail rather than constantly > retrying. > > Added a test for destroying a freezer cgroup containing a stopped > process. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e > src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 3d253af51677dcb4dc48dc9e01bdc2ba80847da9 > src/slave/containerizer/linux_launcher.cpp > c17724b138de9d64856fb85db019e52043fbc7af > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > > Diff: https://reviews.apache.org/r/20818/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
