> On June 16, 2014, 10:19 a.m., Dominic Hamon wrote: > > src/tests/rate_limiting_tests.cpp, line 56 > > <https://reviews.apache.org/r/22639/diff/1/?file=610723#file610723line56> > > > > why is this a macro? a method in the test fixture would work well. > > Jiang Yan Xu wrote: > Theses checks AWAIT_READY, EXPECT_SOME_EQ, ASSERT_SOME are supposed to be > put in a TEST method.
they should work equally well in a test fixture method called from the test. This is far better than introducing a macro. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22639/#review45775 ----------------------------------------------------------- On June 16, 2014, 10:16 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22639/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 10:16 a.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1445 > https://issues.apache.org/jira/browse/MESOS-1445 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22639/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
