> On June 4, 2014, 7:12 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 563 > > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line563> > > > > How about just calling them "unknown_frameworks" or maybe > > "disconnected_frameworks"? but disconnected is an overloaded term because a > > framework might be disconnected even when the master doesn't failover. > > Yifan Gu wrote: > Yeah, I see. unknown_frameworks seems better IMO. Because I found that > the newly elected master actually "forgets" the framework. Even the framework > tried to re-register with the master, the master will reply a > FrameworkRegisteredMessage. > > I don't know if the registerar will be modified later to help the master > memorize the frameworks. > But for now, unknown_frameworks is great. Thanks! Vinod! > > Vinod Kone wrote: > yup. registrar in the future will store framework infos and hence master > will remember them through failovers. > > Vinod Kone wrote: > Actually thinking about it a bit more "unregistered_frameworks" might be > more explicit and easy to understand than "unknown_frameworks". What do you > think?
I think that makes more sense, thank you, Vinod! - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22223/#review44738 ----------------------------------------------------------- On June 16, 2014, 8:45 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22223/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 8:45 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone. > > > Bugs: MESOS-1312 > https://issues.apache.org/jira/browse/MESOS-1312 > > > Repository: mesos-git > > > Description > ------- > > Added orphan_tasks and unregistered_frameworks in state.json to display tasks > that are currently running on the slaves, > but do not belong to any already (re-)registered frameworks. > > > Diffs > ----- > > src/master/http.cpp b565dc6 > src/tests/master_tests.cpp 34df121 > > Diff: https://reviews.apache.org/r/22223/diff/ > > > Testing > ------- > > Added MasterTest.OrphanTasks to test: > 1, Before the framework re-registers with the master: > Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] > field. > That frameworks will appear in the ["not_yet_reregistered_frameworks"] > field. > 2, After the framework re-registers with the master: > There will be no more orphan tasks and not-yet-reregistered frameworks. > 3, Havent' do the WebUI js part. > > > Thanks, > > Yifan Gu > >
