----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22592/#review45843 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On June 13, 2014, 10:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22592/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 10:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1409 > https://issues.apache.org/jira/browse/MESOS-1409 > > > Repository: mesos-git > > > Description > ------- > > Currently status update acknowledgments are sent directly from the scheduler > driver to the slave. > > However, in order to provide correct reconciliation of tasks, the master > needs to hold on to terminal unacknowledged tasks to ensure that it can > correctly identify these until the framework receives the terminal update. > Without this, we are susceptible to MESOS-1389. > > In 0.19.0, the master was updated to handle acknowledgements. Now in 0.20.0, > we can safely send the acknowledgements through the master. > > > Diffs > ----- > > src/sched/sched.cpp 6e14f1cf78b9518a04c35f856fa2358a3d72ddcf > src/tests/fault_tolerance_tests.cpp > 4c6a5c4ecd42a5d0bb4b4d69ab2cd38f842edf7a > src/tests/master_tests.cpp 34df12195d7bbdf77fb6079aa3ad644264b8cfa5 > src/tests/slave_tests.cpp 974293b06697b18b82f0a65f2567ad8bdaa36b3f > > Diff: https://reviews.apache.org/r/22592/diff/ > > > Testing > ------- > > make check (modified those tests that were broken as a result) > > > Thanks, > > Ben Mahler > >
