----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45879 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80939> s/Note/NOTE/ src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80938> s/doesn't require it/allows them/ src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80942> s/Messages/messages/ src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80940> s/Note/NOTE/ src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80946> quotes around Master::Metrics::Frameworks? src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80947> single quotes? src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80948> s/. i.e. Change/, i.e., change/ src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80949> why did you need to extract this into temp? - Vinod Kone On June 17, 2014, 12:17 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 12:17 a.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > > > Diffs > ----- > > src/Makefile.am 3e623cc0137ea4ae9113f9b47a4fc88281ee96c1 > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
